make Deployment PodTemplate not a pointer #16330
Conversation
k8s-github-robot
added
the
size/XXL
|
Labelling this PR as size/XXL |
mikedanese
force-pushed
the
deploy-ptr
branch
from
4da35dc
to
aca8f9d
Compare
|
@ironcladlou @kubernetes/rh-cluster-infra @liggitt @deads2k |
| @@ -208,7 +208,7 @@ type DeploymentSpec struct { | |||
| Selector map[string]string `json:"selector,omitempty"` | |||
|
|
|||
| // Template describes the pods that will be created. | |||
| Template *api.PodTemplateSpec `json:"template,omitempty"` | |||
| Template api.PodTemplateSpec `json:"template"` | |||
There was a problem hiding this comment.
Have we given up on ever having a TemplateRef? As I recall, that's why this is a pointer for ReplicationControllerSpec and I would expect congruence here.
There was a problem hiding this comment.
I discussed this with @bgrant0607 yesterday. The work was half done and no one is working on it or owns it. It's likely not going to get done before 1.2. Until that happens, generated documentation is confusing and incorrect (says this field is optional when it is actually not) and has been for months in the case of the ReplicationController. The change back can be made in conversions when we have a new API version.
There was a problem hiding this comment.
There was a problem hiding this comment.
If we were to add TemplateRef, it would be in a new apiVersion, anyway. Making template a required field for now is more understandable for users.
TemplateRef is one of several issues to consider in the controller API overhaul: #14961. I don't know when I'll have time to get to it, though.
mikedanese
force-pushed
the
deploy-ptr
branch
2 times, most recently
from
49f9fce
to
aec7b2f
Compare
mikedanese
force-pushed
the
deploy-ptr
branch
from
aec7b2f
to
6bbc244
Compare
|
GCE e2e test build/test passed for commit 6bbc244. |
|
LGTM, thanks! |
nikhiljindal
added
the
lgtm
|
@k8s-bot test this [submit-queue is verifying that this PR is safe to merge] |
|
GCE e2e test build/test passed for commit 6bbc244. |
|
Automatic merge from submit-queue |
Auto commit by PR queue bot
…use deployments added deployment-based e2e tests for horizontal pod autoscaling adjusted to changes from PR kubernetes#16330 changed test titles according to PR comments & to merge change from PR kubernetes#16895
No description provided.